mapleFU commented on code in PR #45351:
URL: https://github.com/apache/arrow/pull/45351#discussion_r1931999117
##########
cpp/src/parquet/column_writer.cc:
##########
@@ -2048,8 +2058,7 @@ Status TypedColumnWriterImpl<Int32Type>::WriteArrowDense(
WRITE_ZERO_COPY_CASE(DATE32, Date32Type, Int32Type)
WRITE_SERIALIZE_CASE(DATE64, Date64Type, Int32Type)
WRITE_SERIALIZE_CASE(TIME32, Time32Type, Int32Type)
- WRITE_SERIALIZE_CASE(DECIMAL128, Decimal128Type, Int32Type)
- WRITE_SERIALIZE_CASE(DECIMAL256, Decimal256Type, Int32Type)
Review Comment:
> Perhaps we don't need
I think we need, decimal64 is just decimal type but not limit the precision ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
