etseidl commented on code in PR #7052: URL: https://github.com/apache/arrow-rs/pull/7052#discussion_r1938092925
########## parquet/src/thrift.rs: ########## @@ -282,3 +291,52 @@ fn eof_error() -> thrift::Error { message: "Unexpected EOF".to_string(), }) } + +#[cfg(test)] +mod tests { + use crate::format::{BoundaryOrder, ColumnIndex}; + use crate::thrift::{TCompactSliceInputProtocol, TSerializable}; + + #[test] + pub fn read_boolean_list_field_type() { + // Boolean collection type encoded as 0x01, as used by this crate when writing. + // Values encoded as 1 (true) or 2 (false) as in the current version of the thrift + // documentation. + let bytes = vec![25, 33, 2, 1, 25, 8, 25, 8, 21, 0, 0]; Review Comment: Minor nit: I'd find this easier to decode in my head if these were hex values, but that might just be me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org