jhorstmann commented on code in PR #7052:
URL: https://github.com/apache/arrow-rs/pull/7052#discussion_r1938598303
##########
parquet/src/thrift.rs:
##########
@@ -170,9 +170,13 @@ impl TInputProtocol for TCompactSliceInputProtocol<'_> {
Some(b) => Ok(b),
None => {
let b = self.read_byte()?;
+ // Previous versions of the thrift specification said to use 0
and 1 inside collections,
+ // but that differed from existing implementations.
+ // The specification was updated in
https://github.com/apache/thrift/commit/2c29c5665bc442e703480bb0ee60fe925ffe02e8.
+ // At least the go implementation seems to have followed the
previously documented values.
match b {
0x01 => Ok(true),
Review Comment:
That seems to be the (non-compact) binary protocol, which uses different
encodings and also different tags for the types. I was thinking of doing the
same here though, the error handling does not add much value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
