colin-r-schultz commented on code in PR #45372:
URL: https://github.com/apache/arrow/pull/45372#discussion_r1942123751
##########
cpp/src/arrow/record_batch_test.cc:
##########
@@ -393,6 +399,27 @@ TEST_F(TestRecordBatch, RemoveColumnEmpty) {
AssertBatchesEqual(*added, *batch1);
}
+TEST_F(TestRecordBatch, ColumnsThreadSafety) {
+ const int length = 10;
+
+ random::RandomArrayGenerator gen(42);
+ std::shared_ptr<ArrayData> array_data = gen.ArrayOf(utf8(), length)->data();
+ auto schema = ::arrow::schema({field("f1", utf8())});
+ auto record_batch = RecordBatch::Make(schema, length, {array_data});
+ std::atomic_bool start_flag{false};
+ std::thread t([record_batch, &start_flag]() {
+ start_flag.store(true);
+ auto columns = record_batch->columns();
+ ASSERT_EQ(columns.size(), 1);
Review Comment:
That's a great point, thanks for the suggestion. I've revised my test case.
##########
cpp/src/arrow/record_batch_test.cc:
##########
@@ -393,6 +399,27 @@ TEST_F(TestRecordBatch, RemoveColumnEmpty) {
AssertBatchesEqual(*added, *batch1);
}
+TEST_F(TestRecordBatch, ColumnsThreadSafety) {
+ const int length = 10;
+
+ random::RandomArrayGenerator gen(42);
+ std::shared_ptr<ArrayData> array_data = gen.ArrayOf(utf8(), length)->data();
+ auto schema = ::arrow::schema({field("f1", utf8())});
+ auto record_batch = RecordBatch::Make(schema, length, {array_data});
+ std::atomic_bool start_flag{false};
+ std::thread t([record_batch, &start_flag]() {
+ start_flag.store(true);
+ auto columns = record_batch->columns();
+ ASSERT_EQ(columns.size(), 1);
Review Comment:
That's a great point, thanks for the suggestion. I've revised the test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
