pitrou commented on code in PR #45372:
URL: https://github.com/apache/arrow/pull/45372#discussion_r1942615950


##########
cpp/src/arrow/record_batch_test.cc:
##########
@@ -393,6 +399,34 @@ TEST_F(TestRecordBatch, RemoveColumnEmpty) {
   AssertBatchesEqual(*added, *batch1);
 }
 
+TEST_F(TestRecordBatch, ColumnsThreadSafety) {
+  constexpr size_t kNumThreads = 10;

Review Comment:
   Indeed the emscripten has 
[failed](https://github.com/ursacomputing/crossbow/actions/runs/13154843593/job/36709543256)
 with:
   ```
   [ RUN      ] TestRecordBatch.ColumnsThreadSafety
   unknown file: Failure
   C++ exception with description "thread constructor failed: Resource 
temporarily unavailable" thrown in the test body.
   [  FAILED  ] TestRecordBatch.ColumnsThreadSafety (2 ms)
   ```
   



##########
cpp/src/arrow/record_batch_test.cc:
##########
@@ -393,6 +399,34 @@ TEST_F(TestRecordBatch, RemoveColumnEmpty) {
   AssertBatchesEqual(*added, *batch1);
 }
 
+TEST_F(TestRecordBatch, ColumnsThreadSafety) {
+  constexpr size_t kNumThreads = 10;

Review Comment:
   Indeed the emscripten test has 
[failed](https://github.com/ursacomputing/crossbow/actions/runs/13154843593/job/36709543256)
 with:
   ```
   [ RUN      ] TestRecordBatch.ColumnsThreadSafety
   unknown file: Failure
   C++ exception with description "thread constructor failed: Resource 
temporarily unavailable" thrown in the test body.
   [  FAILED  ] TestRecordBatch.ColumnsThreadSafety (2 ms)
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to