pitrou commented on code in PR #45306: URL: https://github.com/apache/arrow/pull/45306#discussion_r1942945710
########## cpp/thirdparty/README.md: ########## @@ -23,3 +23,19 @@ See the "Build Dependency Management" section in the [C++ Developer Documentation][1]. [1]: https://github.com/apache/arrow/blob/main/docs/source/developers/cpp/building.rst + +## Update versions automatically + +There is a convenient script that update versions in `versions.txt` to +the latest version automatically. You can use it like the following: Review Comment: ```suggestion There is a convenience script that updates versions in `versions.txt` to the latest version automatically. You can use it like the following: ``` ########## cpp/cmake_modules/ThirdpartyToolchain.cmake: ########## @@ -5026,401 +5053,146 @@ endif() include(AWSSDKVariables) -macro(build_awssdk) - message(STATUS "Building AWS C++ SDK from source") - set(AWSSDK_PREFIX "${CMAKE_CURRENT_BINARY_DIR}/awssdk_ep-install") - set(AWSSDK_INCLUDE_DIR "${AWSSDK_PREFIX}/include") +function(build_awssdk) Review Comment: Wow, the code for building AWS SDK is so much nicer now. Thank you! ########## cpp/cmake_modules/s2n-tls.diff: ########## @@ -0,0 +1,42 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + Review Comment: Can you add a comment at the top of this patch pointing to https://github.com/aws/s2n-tls/pull/5076 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
