raulcd commented on code in PR #45425:
URL: https://github.com/apache/arrow/pull/45425#discussion_r1944370078
##########
python/pyarrow/util.py:
##########
@@ -244,15 +244,15 @@ def download_tzdata_on_windows():
tzdata_compressed = os.path.join(tzdata_path, "tzdata.tar.gz")
os.makedirs(tzdata_path, exist_ok=True)
- from urllib.request import urlopen
- with urlopen('https://data.iana.org/time-zones/tzdata-latest.tar.gz') as
response:
+ import requests
+ with requests.get('https://data.iana.org/time-zones/tzdata-latest.tar.gz')
as response: # noqa
Review Comment:
I am slightly concerned. This is a utility function that we provide to users
and it's going to fail with and `ImportError` with this change as we don't have
a dependency on requests.
Should we use the old behavior and only try to use requests in case it fails
or probably better try to use requests and in case of `ImportError` try with
the old urllib request?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
