amoeba commented on code in PR #45425:
URL: https://github.com/apache/arrow/pull/45425#discussion_r1944971722
##########
python/pyarrow/util.py:
##########
@@ -244,15 +244,15 @@ def download_tzdata_on_windows():
tzdata_compressed = os.path.join(tzdata_path, "tzdata.tar.gz")
os.makedirs(tzdata_path, exist_ok=True)
- from urllib.request import urlopen
- with urlopen('https://data.iana.org/time-zones/tzdata-latest.tar.gz') as
response:
+ import requests
+ with requests.get('https://data.iana.org/time-zones/tzdata-latest.tar.gz')
as response: # noqa
Review Comment:
What do you think about
[c13eb9f0e395be813f6836c462ff0bed802877d4](https://github.com/apache/arrow/pull/45425/commits/c13eb9f0e395be813f6836c462ff0bed802877d4)?
Feel free to suggest alternate approaches.
##########
python/pyarrow/util.py:
##########
@@ -244,15 +244,15 @@ def download_tzdata_on_windows():
tzdata_compressed = os.path.join(tzdata_path, "tzdata.tar.gz")
os.makedirs(tzdata_path, exist_ok=True)
- from urllib.request import urlopen
- with urlopen('https://data.iana.org/time-zones/tzdata-latest.tar.gz') as
response:
+ import requests
+ with requests.get('https://data.iana.org/time-zones/tzdata-latest.tar.gz')
as response: # noqa
Review Comment:
What do you think about
https://github.com/apache/arrow/pull/45425/commits/c13eb9f0e395be813f6836c462ff0bed802877d4?
Feel free to suggest alternate approaches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
