kou commented on code in PR #44989:
URL: https://github.com/apache/arrow/pull/44989#discussion_r1946234185
##########
docker-compose.yml:
##########
@@ -1587,6 +1595,7 @@ services:
tz: ${TZ}
r_prune_deps: ${R_PRUNE_DEPS}
r_custom_ccache: ${R_CUSTOM_CCACHE}
+ cmake: ${CMAKE}
Review Comment:
Could you sort this list?
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -4640,6 +4640,7 @@ function(build_orc)
set(ZLIB_HOME
${ZLIB_ROOT}
CACHE STRING "" FORCE)
+ unset(ZLIB_LIBRARY)
Review Comment:
Could you add a comment why we need this?
##########
docker-compose.yml:
##########
@@ -2035,6 +2047,7 @@ services:
args:
repo: ${REPO}
arch: ${ARCH}
+ cmake: ${CMAKE}
Review Comment:
Could you sort this list?
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -4673,7 +4674,6 @@ function(build_orc)
set(STOP_BUILD_ON_WARNING
OFF
CACHE BOOL "" FORCE)
-
Review Comment:
Could you revert this?
We want to keep this empty line to separate parameter set block and
`fetchcontent_makeavailable()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
