raulcd commented on code in PR #44989:
URL: https://github.com/apache/arrow/pull/44989#discussion_r1946325764


##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -4640,6 +4640,7 @@ function(build_orc)
     set(ZLIB_HOME
         ${ZLIB_ROOT}
         CACHE STRING "" FORCE)
+    unset(ZLIB_LIBRARY)

Review Comment:
   I've added something:
   ```
       # From CMake 3.21 onwards the set(CACHE) command does not remove any 
normal
       # variable of the same name from the current scope. We have to manually 
remove
       # the variable via unset to avoid ORC not finding the ZLIB_LIBRARY.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to