zanmato1984 commented on code in PR #44616:
URL: https://github.com/apache/arrow/pull/44616#discussion_r1948487464
##########
python/pyarrow/_dataset.pyx:
##########
@@ -4111,7 +4113,9 @@ class ScanNodeOptions(_ScanNodeOptions):
**kwargs : dict, optional
Scan options. See `Scanner.from_dataset` for possible arguments.
require_sequenced_output : bool, default False
- Assert implicit ordering on data.
+ Batches are yielded sequentially, like single-threaded
Review Comment:
Sorry for not making myself clear enough. By "still needed" I mean the
existence of the parameter `require_sequenced_output` (not the modification to
the docstring). It seems that when introduced in #44083 , it is determined by
the parameter `require_sequenced_output` of `_dataset_to_decl`. Since now you
have replaced the `require_sequenced_output` with `implicit_ordering` in
`_dataset_to_decl`, I wonder if this could be removed as well. Or is "we should
not remove a parameter of a public API" the consideration here?
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
