ritchie46 commented on a change in pull request #9778:
URL: https://github.com/apache/arrow/pull/9778#discussion_r601194739
##########
File path: rust/arrow/src/ffi.rs
##########
@@ -193,6 +204,8 @@ fn to_datatype(format: &str) -> Result<DataType> {
"ttm" => DataType::Time32(TimeUnit::Millisecond),
"ttu" => DataType::Time64(TimeUnit::Microsecond),
"ttn" => DataType::Time64(TimeUnit::Nanosecond),
+ "+l" => DataType::List(Box::new(Default::default())),
+ "+L" => DataType::LargeList(Box::new(Default::default())),
Review comment:
I did overwrite them later, however to make it more clear I now added an
`Option<DataType>` to indicate the child type. This is provided when
`make_array` is called. Internally this is also called by
`ArrowArray::buffer_len`. At that moment the child type is not known, but I
think it's not important as the child data type is not needed to determine the
buffer lengths.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
