ritchie46 commented on pull request #9778: URL: https://github.com/apache/arrow/pull/9778#issuecomment-806467014
> Thanks a lot for this, @ritchie46 . it has the right ideas and looks great so far. 100 > I left some comments throughout the code. > My last general comment would be to add this type to the pyarrow-integration-tests crate, which contains real tests against pyarrow, which allow us to validate the behavior against the C++ implementation. Cool! I think I've tackled all your comments @jorgecarleitao . I also added a test to the `pyarrow-integration-tests-crate`. That was a good one, because it did not succeed. It turns out that we need to provide a name in the `FFI_ArrowSchema` when we provide child data. This was a null ptr, so I replaced this with an empty `""` string, that seemed easiest to me. If you want to tackle that differently, I am open to suggestions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
