parthchandra commented on code in PR #7021:
URL: https://github.com/apache/arrow-rs/pull/7021#discussion_r1952156928
##########
arrow-cast/src/cast/decimal.rs:
##########
@@ -99,10 +100,24 @@ where
I::Native: DecimalCast + ArrowNativeTypeOp,
O::Native: DecimalCast + ArrowNativeTypeOp,
{
+ validate_decimal_precision_and_scale::<O>(output_precision, output_scale)?;
Review Comment:
I don't have a strong opinion on this. I agree with your previous
observation that the array should have been already validated at the time of
building so maybe it is unnecessary to add the additional validation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
