himadripal commented on code in PR #7021:
URL: https://github.com/apache/arrow-rs/pull/7021#discussion_r1953830598
##########
arrow-cast/src/cast/mod.rs:
##########
@@ -9856,6 +9913,276 @@ mod tests {
);
}
+ fn run_decimal_cast_test_case_between_multiple_types(t:
DecimalCastTestConfig) {
+ run_decimal_cast_test_case::<Decimal128Type,
Decimal128Type>(t.clone());
+ run_decimal_cast_test_case::<Decimal128Type,
Decimal256Type>(t.clone());
+ run_decimal_cast_test_case::<Decimal256Type,
Decimal128Type>(t.clone());
+ run_decimal_cast_test_case::<Decimal256Type,
Decimal256Type>(t.clone());
+ }
+
+ #[test]
+ fn test_decimal_to_decimal_coverage() {
+ let test_cases = [
+ // increase precision, increase scale, infallible
+ DecimalCastTestConfig {
+ input_prec: 5,
Review Comment:
Can we have one test for input scale = 0 and output_scale = 0 with any
precision.?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
