adamreeve commented on code in PR #44990:
URL: https://github.com/apache/arrow/pull/44990#discussion_r1953583602
##########
cpp/src/parquet/file_reader.cc:
##########
@@ -314,11 +314,7 @@ class SerializedFile : public ParquetFileReader::Contents {
}
}
- void Close() override {
- if (file_metadata_ && file_metadata_->file_decryptor()) {
- file_metadata_->file_decryptor()->WipeOutDecryptionKeys();
- }
- }
Review Comment:
The PR originally removed all of the "WipeOut" methods as one thread wiping
out a decryptor while it was still in use was the main cause of crashes.
`WipeOutDecryptionKeys` was restored after [this
comment](https://github.com/apache/arrow/pull/44990/commits/c4305bc37d7ca7a44a73b2667a4a4ee02bd3e4d2#r1880648351)
though. I think it's still the case that the decryption properties are shared
in a multi-threaded dataset read, so we do want this code removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
