pitrou commented on code in PR #44990:
URL: https://github.com/apache/arrow/pull/44990#discussion_r1954023096
##########
cpp/src/parquet/column_reader.cc:
##########
@@ -306,8 +306,13 @@ class SerializedPageReader : public PageReader {
// Please refer to the encryption specification for more details:
//
https://github.com/apache/parquet-format/blob/encryption/Encryption.md#44-additional-authenticated-data
- // The ordinal fields in the context below are used for AAD suffix
calculation.
+ // The CryptoContext used by this PageReader.
CryptoContext crypto_ctx_;
+ // This PageReader has its own Decryptor instances in order to be
thread-safe.
Review Comment:
But, still, we should be careful that "copying" doesn't mean the actual
objects are cloned when we've got `shared_ptr` members.
Besides, the nice thing with these factory functions is that they capture
some precomputed encryption parameters such that calling them only creates a
`Decryptor` instance (instead of fetching keys etc.).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
