thisisnic commented on code in PR #45556:
URL: https://github.com/apache/arrow/pull/45556#discussion_r1958719575
##########
r/tests/testthat/test-dplyr-collapse.R:
##########
@@ -142,21 +142,6 @@ test_that("Properties of collapsed query", {
summarize(total = sum(int, na.rm = TRUE)) %>%
mutate(extra = total * 5)
- # print(tbl %>%
- # filter(dbl > 2) %>%
- # select(chr, int, lgl) %>%
- # mutate(twice = int * 2L) %>%
- # group_by(lgl) %>%
- # summarize(total = sum(int, na.rm = TRUE)) %>%
- # mutate(extra = total * 5))
-
- # # A tibble: 3 × 3
- # lgl total extra
- # <lgl> <int> <dbl>
- # 1 FALSE 8 40
- # 2 TRUE 8 40
- # 3 NA 25 125
Review Comment:
Wasn't sure how useful it is - happy to add it back in if you reckon it is?
I was a little confused by the output tibble not actually looking like the
one in the comments, but both the Arrow and dplyr ones match each other so I'm
assuming an update in one of the dplyr verbs that we've already accounted for.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
