jonkeane commented on code in PR #45556: URL: https://github.com/apache/arrow/pull/45556#discussion_r1959788746
########## r/.lintr: ########## @@ -1,23 +1,8 @@ -license: '# Licensed to the Apache Software Foundation (ASF) under one - # or more contributor license agreements. See the NOTICE file - # distributed with this work for additional information - # regarding copyright ownership. The ASF licenses this file - # to you under the Apache License, Version 2.0 (the - # "License"); you may not use this file except in compliance - # with the License. You may obtain a copy of the License at - # - # http://www.apache.org/licenses/LICENSE-2.0 - # - # Unless required by applicable law or agreed to in writing, - # software distributed under the License is distributed on an - # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY - # KIND, either express or implied. See the License for the - # specific language governing permissions and limitations - # under the License.' linters: linters_with_defaults( indentation_linter = NULL, line_length_linter = line_length_linter(120), object_name_linter = NULL, + return_linter = NULL, Review Comment: _nods_ got it. It's funny cause both of those IIUC do follow the "implicit return, unless you're returning early" rule. I guess there might be some room for interpretation around if the last thing is an `if`/`else` then that's the same thing as the last thing. Agreed that these we should keep as they are. Are there a small enough number of these kinds of false positives that we could use the `except` or `except_regex` option to except them? https://lintr.r-lib.org/reference/return_linter.html#arg-except-except-regex I'm fine if we don't but that's one way to get some of the niceness of the linter still -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
