crepererum commented on code in PR #7152: URL: https://github.com/apache/arrow-rs/pull/7152#discussion_r1960134182
########## object_store/src/payload.rs: ########## @@ -19,7 +19,7 @@ use bytes::Bytes; use std::sync::Arc; /// A cheaply cloneable, ordered collection of [`Bytes`] -#[derive(Debug, Clone)] +#[derive(Debug, Clone, PartialEq, Eq)] Review Comment: Good question. I think NOT equalizing chunking might be the more correct Eq implementation, because if you want to test optimizations / implementation details, this is important. I think we should document it though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
