crepererum commented on code in PR #7152:
URL: https://github.com/apache/arrow-rs/pull/7152#discussion_r1961634737
##########
object_store/src/lib.rs:
##########
@@ -916,7 +916,7 @@ pub struct ObjectMeta {
}
/// Options for a get request, such as range
-#[derive(Debug, Default, Clone)]
+#[derive(Debug, Default, Clone, PartialEq, Eq)]
pub struct GetOptions {
Review Comment:
Should we require extensions to implement not only `Any` but also `Eq` and
`PartialEq` w/ their own type? That would require some additional bookkeeping
code withing `AnyMap` to store the vtable entries though, or don't use `Any` at
all but `trait Extension: Eq + std::fmt::Debug` or something like that. The
more I think about it, the more convinced I am that a proper new trait would be
better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
