Xuanwo commented on code in PR #7160:
URL: https://github.com/apache/arrow-rs/pull/7160#discussion_r1964897950


##########
object_store/src/extensions.rs:
##########
@@ -0,0 +1,257 @@
+use std::{
+    any::{Any, TypeId},
+    collections::HashMap,
+    sync::Arc,
+};
+
+/// Trait that must be implemented by extensions.
+pub trait Extension: std::fmt::Debug + Send + Sync {

Review Comment:
   Hi, I'm concerned about adding such an API in `object_store`, especially a 
model tailored for specific use cases like metrics and tracing.
   
   Have we considered adding a `TracingObjectStore` that wraps another object 
store and adds traces for every API call? I think this approach is more 
extensible and can help avoid making changes for every action.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to