arashandishgar commented on code in PR #45577:
URL: https://github.com/apache/arrow/pull/45577#discussion_r1969129327
##########
cpp/src/arrow/compute/kernels/scalar_string_test.cc:
##########
@@ -1958,6 +1960,29 @@ TYPED_TEST(TestBaseBinaryKernels, ExtractRegex) {
R"([{"letter": "a", "digit": "1"}, {"letter": "b", "digit":
"3"}])",
&options);
}
+TYPED_TEST(TestBaseBinaryKernels, ExtractRegexSapn) {
+ ExtractRegexSpanOptions options{"(?P<letter>[ab])(?P<digit>\\d)"};
Review Comment:
you are right and I've completely forget the optional case. (Just for
clarification) . Do you mean such a senario?
`ExtractRegexSpanOptions options{"(?P<letter>[ab])(?P<digit>\\d)?"};
this->CheckUnary(
"extract_regex_span", R"(["a1", "a", "b2", "b", "c3"])", out_type,
R"([{"letter_span":[0,1], "digit_span":[1,1]},
{"letter_span":[0,1], "digit_span":null},
{"letter_span":[0,1], "digit_span":[1,1]},
{"letter_span":[0,1], "digit_span":null},
null])",
&options);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
