arashandishgar commented on code in PR #45577:
URL: https://github.com/apache/arrow/pull/45577#discussion_r1969166348
##########
cpp/src/arrow/compute/kernels/scalar_string_test.cc:
##########
@@ -314,6 +314,7 @@ TYPED_TEST(TestBinaryKernels, NonUtf8Regex) {
this->MakeArray({"\xfc\x40", "this \xfc\x40 that
\xfc\x40"}),
this->MakeArray({"bazz", "this bazz that \xfc\x40"}),
&options);
}
+ // TODO the following test is broken
Review Comment:
This is not only about this test, I should write the same test in this case
for extract_regex_span. But When I check the output of compute function of the
test, I found It's empy. I mean The following code.
` ExtractRegexOptions options("(?P<letter>[\\xfc])(?P<digit>\\d)");
auto datum = CallFunction("extract_regex",
{this->MakeArray({"foo\xfc 1bar",
"\x02\xfc\x40"})}, &options).ValueOrDie();
ARROW_LOGGER_INFO("", datum.ToString());`
I mean What is the purpose of the test and What should I Check in this test
case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
