paleolimbot commented on code in PR #710:
URL: https://github.com/apache/arrow-nanoarrow/pull/710#discussion_r1971025651
##########
src/nanoarrow/common/array.c:
##########
@@ -1157,9 +1175,31 @@ static int ArrowArrayViewValidateDefault(struct
ArrowArrayView* array_view,
return EINVAL;
}
}
+
+ if ((array_view->storage_type == NANOARROW_TYPE_LIST_VIEW) &&
Review Comment:
I also might be misunderstanding 🙂
You do validate both the offsets and the sizes in the full validation check,
and my point is that here the first and last offsets and/or sizes are not more
or less important than any of the others so I think it makes sense to do them
all once, in the same place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
