WillAyd commented on code in PR #710:
URL: https://github.com/apache/arrow-nanoarrow/pull/710#discussion_r1971871509
##########
src/nanoarrow/common/array.c:
##########
@@ -1157,9 +1175,31 @@ static int ArrowArrayViewValidateDefault(struct
ArrowArrayView* array_view,
return EINVAL;
}
}
+
+ if ((array_view->storage_type == NANOARROW_TYPE_LIST_VIEW) &&
Review Comment:
> You do validate both the offsets and the sizes in the full validation check
I think you meant to say _default validation check_ here, in which case
understood and happy to move those checks to full. The only nuance there again
is that it probably will make the test parametrization more complicated, as the
list types keep the first/last offset checks in their default validation
implementation and test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
