paleolimbot commented on code in PR #45459:
URL: https://github.com/apache/arrow/pull/45459#discussion_r1974521159
##########
cpp/src/parquet/arrow/schema.cc:
##########
@@ -428,13 +520,20 @@ Status FieldToNode(const std::string& name, const
std::shared_ptr<Field>& field,
}
case ArrowTypeId::EXTENSION: {
auto ext_type =
std::static_pointer_cast<::arrow::ExtensionType>(field->type());
- // Built-in JSON extension is handled differently.
+ // Built-in JSON extension and GeoArrow are handled differently.
if (ext_type->extension_name() == std::string("arrow.json")) {
// Set physical and logical types and instantiate primitive node.
type = ParquetType::BYTE_ARRAY;
logical_type = LogicalType::JSON();
break;
+ } else if (arrow_properties.write_geospatial_logical_types() &&
Review Comment:
I'll write a top-level comment below about this one...I basically kept it
for now but moved everything to a place where the JSON dependency can be
removed (and I'm totally happy to remove the JSON part and tackle getting this
to a place where it's actually useful in a separate PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
