paleolimbot commented on code in PR #45459:
URL: https://github.com/apache/arrow/pull/45459#discussion_r1974521566
##########
cpp/src/parquet/column_writer.cc:
##########
@@ -1792,6 +1831,12 @@ Status
TypedColumnWriterImpl<DType>::WriteArrowDictionary(
page_statistics_->IncrementNullCount(num_chunk_levels - non_null_count);
page_statistics_->IncrementNumValues(non_null_count);
page_statistics_->Update(*referenced_dictionary, /*update_counts=*/false);
+
+ if constexpr (std::is_same<T, ByteArray>::value) {
+ if (chunk_geometry_statistics_ != nullptr) {
+ chunk_geometry_statistics_->Update(*referenced_dictionary);
Review Comment:
I updated this to throw (but if you try to write a dictionary here it fails
at the schema conversion step anyway)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
