CurtHagenlocher commented on code in PR #2566: URL: https://github.com/apache/arrow-adbc/pull/2566#discussion_r1977738949
########## csharp/src/Drivers/BigQuery/readme.md: ########## @@ -42,17 +42,23 @@ The following parameters can be used to configure the driver behavior. The param https://cloud.google.com/dotnet/docs/reference/Google.Cloud.BigQuery.V2/latest/Google.Cloud.BigQuery.V2.QueryOptions#Google_Cloud_BigQuery_V2_QueryOptions_AllowLargeResults +**adbc.bigquery.billing_project_id**<br> + The [Project ID](https://cloud.google.com/resource-manager/docs/creating-managing-projects) used for accessing billing BigQuery. If not specified, will default to the detected project ID. + **adbc.bigquery.client_id**<br> The OAuth client ID. Required for `user` authentication. **adbc.bigquery.client_secret**<br> The OAuth client secret. Required for `user` authentication. +**adbc.bigquery.client.timeout**<br> + Optional. Sets the timeout (in seconds) for the BigQueryClient. Similar to a ConnectionTimeout in ODBC. Review Comment: It's a bit of a nitpick, but ODBC doesn't actually have a `ConnectionTimeout` or `CommandTimeout`. These are properties surfaced on the BCL's managed wrapper for ODBC. The ODBC standard is to set attributes on the connection and statement, respectively, with attribute identifiers of `SQL_ATTR_CONNECTION_TIMEOUT` and `SQL_ATTR_QUERY_TIMEOUT`. As such, the analogy as written isn't necessarily helpful for someone familiar with ODBC. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
