davidhcoe commented on code in PR #2566:
URL: https://github.com/apache/arrow-adbc/pull/2566#discussion_r1978187995
##########
csharp/src/Drivers/BigQuery/BigQueryStatement.cs:
##########
@@ -126,13 +122,13 @@ public override UpdateResult ExecuteUpdate()
QueryOptions options = ValidateOptions();
GetQueryResultsOptions getQueryResultsOptions = new
GetQueryResultsOptions();
- if
(this.Options?.TryGetValue(BigQueryParameters.GetQueryResultsOptionsTimeoutMinutes,
out string? timeoutMinutes) == true)
+ if
(this.Options?.TryGetValue(BigQueryParameters.GetQueryResultsOptionsTimeout,
out string? timeoutSeconds) == true)
{
- if (int.TryParse(timeoutMinutes, out int minutes))
+ if (int.TryParse(timeoutSeconds, out int seconds))
{
- if (minutes >= 0)
+ if (seconds >= 0)
{
- getQueryResultsOptions.Timeout =
TimeSpan.FromMinutes(minutes);
+ getQueryResultsOptions.Timeout =
TimeSpan.FromMinutes(seconds);
Review Comment:
I wrestled with changing this outright vs having two options. I needed
something more granular for the tests, I thought having two options would be
confusing, but I decided to leave the two options for the
BigQueryTestConfiguration because it's more likely a configuration file is set
with timeoutMinutes and I just convert that. I dont think there are many, if
any, consumers at this point, so I decided it was best to just make a clean
break to seconds for the parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
