zanmato1984 commented on code in PR #45421:
URL: https://github.com/apache/arrow/pull/45421#discussion_r1979076598
##########
cpp/src/arrow/acero/util_test.cc:
##########
@@ -184,5 +185,117 @@ TEST(FieldMap, ExtensionTypeHashJoin) {
EXPECT_EQ(i.get(0), 0);
}
+template <typename Queue>
+void ConcurrentQueueBasicTest(Queue& queue) {
+ ASSERT_TRUE(queue.Empty());
Review Comment:
```suggestion
#ifndef ARROW_ENABLE_THREADING
GTEST_SKIP() << "Test requires threading enabled";
#endif
ASSERT_TRUE(queue.Empty());
```
##########
cpp/src/arrow/acero/concurrent_queue_internal.h:
##########
@@ -33,9 +34,15 @@ class ConcurrentQueue {
public:
// Pops the last item from the queue. Must be called on a non-empty queue
//
+
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
