gitmodimo commented on code in PR #45421:
URL: https://github.com/apache/arrow/pull/45421#discussion_r1979303694
##########
cpp/src/arrow/acero/concurrent_queue_internal.h:
##########
@@ -35,7 +36,12 @@ class ConcurrentQueue {
//
T Pop() {
Review Comment:
Hmmm. I like the idea of removing potential unsafe call. I thought Pop is is
used but in fact only TryPop() is used.
If we could eliminate `Front` as well...
Front is unfortunately heavily used in sorted_merge_node and asof_join_node.
Any ideas?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
