zanmato1984 commented on PR #45421: URL: https://github.com/apache/arrow/pull/45421#issuecomment-2698291583
> > > 1. ARROW_ACERO_EXPORT > > > > > > Oh, I guess you'll need this even in this PR (not related to making the class public API, but to letting tests compile). The CI will fail otherwise (hopefully). > > > > Apart from missing override seem like build has succeeded I just realized that the classes are templates so there's nothing to really export 😃 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
