Dandandan commented on a change in pull request #9824:
URL: https://github.com/apache/arrow/pull/9824#discussion_r602816405
##########
File path: rust/arrow/benches/equal.rs
##########
@@ -38,10 +38,10 @@ fn add_benchmark(c: &mut Criterion) {
let arr_a_nulls = create_primitive_array::<Float32Type>(512, 0.5);
c.bench_function("equal_nulls_512", |b| b.iter(||
bench_equal(&arr_a_nulls)));
- let arr_a = create_string_array(512, 0.0);
+ let arr_a = create_string_array::<i32>(512, 0.0);
Review comment:
Not part of the PR - but I notice this benchmark is strange / not very
representative as it is testing two of the same arrays to be equal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
