Dandandan commented on a change in pull request #9824:
URL: https://github.com/apache/arrow/pull/9824#discussion_r602853980
##########
File path: rust/arrow/benches/equal.rs
##########
@@ -38,10 +38,10 @@ fn add_benchmark(c: &mut Criterion) {
let arr_a_nulls = create_primitive_array::<Float32Type>(512, 0.5);
c.bench_function("equal_nulls_512", |b| b.iter(||
bench_equal(&arr_a_nulls)));
- let arr_a = create_string_array(512, 0.0);
+ let arr_a = create_string_array::<i32>(512, 0.0);
Review comment:
Yeah, and also the seeds need to be different in that case, earlier I
found a benchmark which created two same arrays, but as the code uses the same
`42` seed, it still had to equivalent arrays :shrug:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
