kou commented on code in PR #45470: URL: https://github.com/apache/arrow/pull/45470#discussion_r1984240942
########## ci/docker/python-free-threaded-wheel-musllinux-test-imports.dockerfile: ########## @@ -0,0 +1,48 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +ARG base +FROM ${base} + +RUN apk add --no-cache bash build-base bzip2-dev dpkg dpkg-dev g++ git libffi-dev libnsl-dev libtirpc-dev \ Review Comment: Can we remove `dpkg` and `dpkg-dev`? ########## ci/docker/python-free-threaded-wheel-musllinux-test-imports.dockerfile: ########## @@ -0,0 +1,48 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +ARG base +FROM ${base} + +RUN apk add --no-cache bash build-base bzip2-dev dpkg dpkg-dev g++ git libffi-dev libnsl-dev libtirpc-dev \ + linux-headers ncurses-dev openssl-dev pkgconf tzdata zlib-dev Review Comment: Could you use one line per package for easy to read? ```suggestion RUN apk add --no-cache \ bash \ build-base \ bzip2-dev \ dpkg \ dpkg-dev \ g++ \ git \ libffi-dev \ libnsl-dev \ libtirpc-dev \ linux-headers \ ncurses-dev \ openssl-dev \ pkgconf \ tzdata \ zlib-dev ``` ########## ci/docker/python-free-threaded-wheel-musllinux-test-imports.dockerfile: ########## @@ -0,0 +1,48 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +ARG base +FROM ${base} + +RUN apk add --no-cache bash build-base bzip2-dev dpkg dpkg-dev g++ git libffi-dev libnsl-dev libtirpc-dev \ + linux-headers ncurses-dev openssl-dev pkgconf tzdata zlib-dev + +# Install Python3.13.2 without GIL +RUN wget https://github.com/python/cpython/archive/refs/tags/v3.13.2.tar.gz && \ + tar -xzf v3.13.2.tar.gz && \ + rm v3.13.2.tar.gz && \ + cd cpython-3.13.2/ && \ + gnuArch="$(dpkg-architecture --query DEB_BUILD_GNU_TYPE)" && \ + ./configure --build="$gnuArch" --disable-gil --with-ensurepip && \ + make -j && \ + make install && \ + cd ../ && \ + rm -rf cpython-3.13.2/ + +# Add symlinks for idle, pip, pydoc, python and python-config +RUN for src in idle3 pip3 pydoc3 python3 python3-config; do \ + dst="$(echo "$src" | tr -d 3)"; \ + [ -s "/usr/local/bin/$src" ]; \ + [ ! -e "/usr/local/bin/$dst" ]; \ + ln -svT "$src" "/usr/local/bin/$dst"; \ + done Review Comment: Why do we need this? What scripts do require this? Can we change them to use `python3` not `python`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
