CurtHagenlocher commented on code in PR #2579:
URL: https://github.com/apache/arrow-adbc/pull/2579#discussion_r1985514752
##########
csharp/src/Drivers/Apache/Spark/SparkHttpConnection.cs:
##########
@@ -205,6 +214,10 @@ private HttpClientHandler NewHttpClientHandler()
{
return new
AuthenticationHeaderValue(BasicAuthenticationScheme,
Convert.ToBase64String(Encoding.UTF8.GetBytes($"{username}:")));
}
+ else if (!string.IsNullOrEmpty(access_token) && authType ==
SparkAuthType.OAuth)
+ {
+ return new
AuthenticationHeaderValue(BearerAuthenticationScheme, access_token);
Review Comment:
It seems like mechanically, the only difference between `token` and `oauth`
are the names and values of the connection parameters; an
`adbc.spark.auth_type` of `token` with an `adbc.spark.token` property produces
an identical outcome as an 'adbc.spark.auth_type` of `oauth` with an
`adbc.spark.access_token` property. Is this expected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
