eric-wang-1990 commented on code in PR #2579:
URL: https://github.com/apache/arrow-adbc/pull/2579#discussion_r1990107361
##########
csharp/src/Drivers/Apache/Spark/SparkHttpConnection.cs:
##########
@@ -205,6 +214,10 @@ private HttpClientHandler NewHttpClientHandler()
{
return new
AuthenticationHeaderValue(BasicAuthenticationScheme,
Convert.ToBase64String(Encoding.UTF8.GetBytes($"{username}:")));
}
+ else if (!string.IsNullOrEmpty(access_token) && authType ==
SparkAuthType.OAuth)
+ {
+ return new
AuthenticationHeaderValue(BearerAuthenticationScheme, access_token);
Review Comment:
Yes, they should all put the token at the Bearer header.
The reason I add another auth_type and another access_token is to
differentiate from existing token mode, and we will need to support other OAuth
features like service principal in the future, which will follow the oauth
pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
