mbutrovich commented on code in PR #7250:
URL: https://github.com/apache/arrow-rs/pull/7250#discussion_r1987306608
##########
parquet/src/arrow/array_reader/primitive_array.rs:
##########
@@ -160,10 +159,7 @@ where
}
PhysicalType::FLOAT => ArrowType::Float32,
PhysicalType::DOUBLE => ArrowType::Float64,
- PhysicalType::INT96 => match target_type {
- ArrowType::Timestamp(TimeUnit::Nanosecond, _) =>
target_type.clone(),
- _ => unreachable!("INT96 must be timestamp nanosecond"),
- },
+ PhysicalType::INT96 => ArrowType::FixedSizeBinary(12),
Review Comment:
I went with this approach first, but the conversion logic happens in
`IntoBuffer` for the `Vec<Int96>` type and that doesn't take any args, so I
couldn't figure out how to get different types of `Buffer`s from that method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
