alamb commented on code in PR #7250:
URL: https://github.com/apache/arrow-rs/pull/7250#discussion_r1989895129
##########
parquet/src/arrow/array_reader/primitive_array.rs:
##########
@@ -160,10 +159,7 @@ where
}
PhysicalType::FLOAT => ArrowType::Float32,
PhysicalType::DOUBLE => ArrowType::Float64,
- PhysicalType::INT96 => match target_type {
- ArrowType::Timestamp(TimeUnit::Nanosecond, _) =>
target_type.clone(),
- _ => unreachable!("INT96 must be timestamp nanosecond"),
- },
+ PhysicalType::INT96 => ArrowType::FixedSizeBinary(12),
Review Comment:
I played around with it today and we could change the `IntoBuffer` trait to
take a datatype which seemed to work for me. Here is a PR to your branch
- https://github.com/mbutrovich/arrow-rs/pull/1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
