thisisnic commented on code in PR #45685:
URL: https://github.com/apache/arrow/pull/45685#discussion_r1992098277
##########
r/tests/testthat/test-dataset.R:
##########
@@ -915,7 +915,7 @@ test_that("Dataset and query print methods", {
"dbl: double",
"lgl: bool",
"chr: string",
- "fct: dictionary<values=string, indices=int32>",
+ "fct: dictionary<values=string, indices=int8>",
Review Comment:
Apologies, travelling at the moment, and can take a look tomorrow, but how
I'll do it if nobody gets there first; if it's not too prevalent across the
tests, something like this.
Add this to `r/tests/testthat/helper-arrow.R`:
```
arrow_cpp_version_at_least <- function(version) {
current_version <- arrow::arrow_info()$build_info$cpp_version
numeric_version(current_version) >= numeric_version(version)
}
```
Replace the above test with something like:
```
test_that("Dataset and query print methods", {
ds <- open_dataset(hive_dir)
dict_index_type <- ifelse(arrow_cpp_version_at_least("19.0.1"), "int8",
"int32")
expect_output(
print(ds),
paste(
"FileSystemDataset with 2 Parquet files",
"8 columns",
"int: int32",
"dbl: double",
"lgl: bool",
"chr: string",
paste("fct: dictionary<values=string, indices=", dict_index_type, ">",
sep = ""),
"ts: timestamp[us, tz=UTC]",
"group: int32",
"other: string",
sep = "\n"
),
fixed = TRUE
)
....
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
