lesterfan commented on code in PR #45685:
URL: https://github.com/apache/arrow/pull/45685#discussion_r1984411900
##########
cpp/src/parquet/arrow/reader_internal.cc:
##########
@@ -547,7 +563,7 @@ Status TransferBinary(RecordReader* reader, MemoryPool*
pool,
std::shared_ptr<ChunkedArray>* out) {
if (reader->read_dictionary()) {
Review Comment:
That is indeed the intention here. In the case where the writer doesn't set
the dictionary type, `TransferBinary` will call `TransferDictionary`
[here](https://github.com/apache/arrow/blob/d88ef57a737b246c93e07ff98c19ff488bca1c59/cpp/src/parquet/arrow/reader_internal.cc#L549)
which still hardcodes the `int32` type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
