paleolimbot commented on code in PR #719:
URL: https://github.com/apache/arrow-nanoarrow/pull/719#discussion_r1996558301


##########
.github/workflows/examples.yaml:
##########
@@ -107,15 +113,18 @@ jobs:
           ctest .
 
       - name: Comprehensive CMake example
+        shell: bash
+        env:
+          EXTRA_CMAKE_INSTALL: ${{ matrix.config.label == 'windows' && 
'--config=Debug' || '' }}
         run: |
           cd examples/cmake-scenarios
           ./build.sh
-          for dir in scratch/build*; do
-            ./${dir}/minimal_cpp_app;
-            echo ;
-          done
+          ./run.sh
 
       - name: Meson example
+        # This example doesn't seem to work on Windows
+        if: matrix.config.label != 'windows'

Review Comment:
   @WillAyd  I'll open an issue for this! I think it works but needs some 
environment-on-ci debugging!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to