paleolimbot commented on PR #719:
URL: https://github.com/apache/arrow-nanoarrow/pull/719#issuecomment-2734806519

   > then add a nanoarrow::nanoarrow alias to it
   
   Ok, I added this + tests to make sure it works in both the fetch and 
installed cases. You and @m-kuhn are right that this is sort of annoying if you 
want the value of BUILD_SHARED_LIBS to do the work for you.
   
   > For my understanding, for downstream libraries that link to nanoarrow, 
this will mean to be used like this:
   
   It would probably be more like the `if(BUILD_SHARED_LIBS) ... 
target_link_libraries(... nanoarrow::nanoarrow_shared)` like Jacob demoed 
above...both targets are always available but you'd have to decide which one 
you want. There are some cases where you want to namespace the symbols + 
statically link even though you yourself are building a shared library. In any 
case, linking to `nanoarrow::nanoarrow` should do the same thing that it did 
before this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to