pitrou commented on code in PR #45822:
URL: https://github.com/apache/arrow/pull/45822#discussion_r2003176259
##########
cpp/src/arrow/compute/row/grouper.h:
##########
@@ -120,6 +121,15 @@ class ARROW_EXPORT Grouper {
virtual Result<Datum> Consume(const ExecSpan& batch, int64_t offset = 0,
int64_t length = -1) = 0;
+ /// Like Consume, but groups not already encountered emit null instead of
+ /// generating a new group id.
+ virtual Result<Datum> Lookup(const ExecSpan& batch, int64_t offset = 0,
+ int64_t length = -1) = 0;
+
+ /// Like Consume, but only populates the Grouper without returning the group
ids.
+ virtual Status Populate(const ExecSpan& batch, int64_t offset = 0,
Review Comment:
My plan is to convert the `std::vector<std::string>` into an actual
`ArrayData` (or `ArraySpan` perhaps). This will also help for
https://github.com/apache/arrow/issues/45732 (since we'll use the Cast kernels
to cast from string to the actual key type).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
