pitrou commented on code in PR #45822:
URL: https://github.com/apache/arrow/pull/45822#discussion_r2005872095
##########
cpp/src/arrow/compute/row/grouper.cc:
##########
@@ -329,6 +330,8 @@ Status CheckAndCapLengthForConsume(int64_t batch_length,
int64_t& consume_offset
return Status::OK();
}
+enum class GrouperMode { kPopulate, kConsume, kLookup };
Review Comment:
Hmm, I think this is going to get clumsy because the primitive functions
would need to allocate and provide a number of temporary buffers (such as
`offsets_batch` and `key_bytes_batch`). We could of course introduce dedicated
structures to hold these.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
