paleolimbot commented on code in PR #45459: URL: https://github.com/apache/arrow/pull/45459#discussion_r2007939590
########## cpp/src/parquet/CMakeLists.txt: ########## @@ -259,6 +262,12 @@ endif() if(NOT PARQUET_MINIMAL_DEPENDENCY) list(APPEND PARQUET_SHARED_LINK_LIBS arrow_shared) + # TODO(paleolimbot): Make sure this is OK or remove if not! + if(ARROW_JSON) Review Comment: I am happy to do either here, although I did notice that there are >60 references to `PARQUET_REQUIRE_ENCRYPTION` in our codebase and so I'd like to be very sure that this is the desired direction before replicating those references to ensure geoarrow support. (`ARROW_JSON` is the mechananism that the canonical extension types that require JSON parsing use to determine whether they are or are not supported in a given Arrow C++ build). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
