paleolimbot commented on code in PR #45459: URL: https://github.com/apache/arrow/pull/45459#discussion_r2007969246
########## cpp/src/parquet/arrow/writer.cc: ########## @@ -526,9 +526,17 @@ Status FileWriter::Make(::arrow::MemoryPool* pool, Status GetSchemaMetadata(const ::arrow::Schema& schema, ::arrow::MemoryPool* pool, const ArrowWriterProperties& properties, std::shared_ptr<const KeyValueMetadata>* out) { - if (!properties.store_schema()) { + if (!properties.store_schema() && + !properties.geo_crs_context()->HasProjjsonCrsFields()) { Review Comment: I reverted this change (agreed that it was hard to figure out exactly what would happen for the various combinations of store_schema/HasProjjsonCrsFields()) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org