jonkeane commented on a change in pull request #9846:
URL: https://github.com/apache/arrow/pull/9846#discussion_r604095465
##########
File path: r/tests/testthat.R
##########
@@ -19,4 +19,4 @@ library(testthat)
library(arrow)
library(tibble)
-test_check("arrow")
+test_check("arrow", reporter="location")
Review comment:
We will probably want to make this change only happen on CI so that the
standard reporter is used when we submit to CRAN. We could have this trigger on
`ARROW_R_DEV` which is (almost?) always set on CI and isn't a terrible
overloading of the meaning.
We also could use `reporter = MultiReporter("check", "location")` which
should give us decent info in the check log, but also more detailed information
for the artifact (this config basically concatenates the two reporter outputs
in the output, but in reverse order)
##########
File path: ci/scripts/r_test.sh
##########
@@ -73,7 +73,7 @@ SCRIPT="as_cran <-
!identical(tolower(Sys.getenv('NOT_CRAN')), 'true')
}
rcmdcheck::rcmdcheck(build_args = '--no-build-vignettes', args =
c('--no-manual', '--ignore-vignettes', '--run-donttest'), error_on = 'warning',
check_dir = 'check')
}"
-echo "$SCRIPT" | ${R_BIN} --no-save
+echo "$SCRIPT" | timeout -k 3600 3600 ${R_BIN} --no-save
Review comment:
I wonder if this is better or if we should add to line 74 the argument
`timeout = 3600` which will timeout at the check level (and will mark the build
as failed if the timeout happens).
##########
File path: .github/workflows/r.yml
##########
@@ -86,6 +86,9 @@ jobs:
- name: Dump install logs
run: cat r/check/arrow.Rcheck/00install.out
if: always()
+ - name: Dump test logs
+ run: cat r/check/arrow.Rcheck/tests/testthat.Rout
Review comment:
```suggestion
run: cat r/check/arrow.Rcheck/tests/testthat.Rout*
```
_it turns out_ that if there's a test failure, the output is written to
`r/check/arrow.Rcheck/tests/testthat.Rout.fail`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
