westonpace commented on a change in pull request #9846:
URL: https://github.com/apache/arrow/pull/9846#discussion_r604150422
##########
File path: ci/scripts/r_test.sh
##########
@@ -73,7 +73,7 @@ SCRIPT="as_cran <-
!identical(tolower(Sys.getenv('NOT_CRAN')), 'true')
}
rcmdcheck::rcmdcheck(build_args = '--no-build-vignettes', args =
c('--no-manual', '--ignore-vignettes', '--run-donttest'), error_on = 'warning',
check_dir = 'check')
}"
-echo "$SCRIPT" | ${R_BIN} --no-save
+echo "$SCRIPT" | timeout -k 3600 3600 ${R_BIN} --no-save
Review comment:
Yes, this is much better. My initial searching on rcmdcheck didn't find
any timeout arg otherwise I would have gone this route originally.
##########
File path: .github/workflows/r.yml
##########
@@ -86,6 +86,9 @@ jobs:
- name: Dump install logs
run: cat r/check/arrow.Rcheck/00install.out
if: always()
+ - name: Dump test logs
+ run: cat r/check/arrow.Rcheck/tests/testthat.Rout
Review comment:
Ah, good catch. Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
